Add Open Documentation button to signals #64411
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fire-forge
force-pushed
the
signal-doc
branch
2 times, most recently
from
840ef6d to
103d8b9
Compare
|
I am running into an issue where pressing the Open Documentation button occasionally doesn't do anything. After much testing and looking through the source code, I can't figure out the specific conditions that cause the bug to occur. Any help with this would be appreciated! Aside from that, the PR should be ready for review. |
fire-forge
commented
Aug 20, 2022
| @@ -919,7 +919,6 @@ void EditorProperty::menu_option(int p_option) { | |||
| } break; | |||
| case MENU_OPEN_DOCUMENTATION: { | |||
| ScriptEditor::get_singleton()->goto_help(doc_path); | |||
| EditorNode::get_singleton()->set_visible_editor(EditorNode::EDITOR_SCRIPT); | |||
There was a problem hiding this comment.
ScriptEditor::get_singleton()->goto_help() already calls this function, so this line was redundant.
|
Superseded by #81092 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an Open Documentation button to the context menu of signals in the Node dock.
Related to #59680, where an Open Documentation button was added to the context menu of properties in the inspector.